Bug 19036: Add ability to enable credit number for only some credit types

[koha-equinox.git] / Koha / Account / Line.pm

diff --git a/Koha/Account/Line.pm b/Koha/Account/Line.pm
index 5272b34..d4fbd6b 100644 (file)
--- a/Koha/Account/Line.pm
+++ b/Koha/Account/Line.pm
@@ -886,7 +886,13 @@ sub store {
     my ($self) = @_;
 
     my $AutoCreditNumber = C4::Context->preference('AutoCreditNumber');
-    if ($AutoCreditNumber && !$self->in_storage && $self->is_credit && !$self->credit_number) {
+    my $credit_number_enabled = $self->is_credit && $self->credit_type->credit_number_enabled;
+
+    if ($AutoCreditNumber && $credit_number_enabled && !$self->in_storage) {
+        if (defined $self->credit_number) {
+            Koha::Exceptions::Account->throw('AutoCreditNumber is enabled but credit_number is already defined');
+        }
+
         my $rs = Koha::Database->new->schema->resultset($self->_type);
 
         if ($AutoCreditNumber eq 'incremental') {