Bug 11337: Remove the C4::Serials::GetSubscriptions routine
authorJonathan Druart <jonathan.druart@biblibre.com>
Wed, 4 Dec 2013 14:23:17 +0000 (15:23 +0100)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Mon, 13 Apr 2015 13:36:19 +0000 (10:36 -0300)
commit27b534dc56f139d10a45375f2273510ac6222874
treebc339d241229dc34cb5eb2273c7a7cc6cd7db478
parent229db83ee0e32b320ca5f66947ab8e6d7d08b922
Bug 11337: Remove the C4::Serials::GetSubscriptions routine

Since SearchSubscriptions is the way to search subscriptions, each call
to GetSubscriptions could be replaced by a call to SearchSubscriptions.

Test plan:
Verify following pages display the same thing as before this patch:
- catalogue/detail.pl
- opac/opac-ISBDdetail.pl
- opac/opac-detail.pl

Verify the following page returns correct results:
- serials/checkexpiration.pl

Verify the Serials UT file still passes:
- prove t/db_dependent/Serials.t

Note: The title filter on checkexpiration now only searches on the title
DB field. I don't think it is a regression, it should be the way to use
this field. Maybe should we add new search fields on this form.
Bug 5337 reintroduces a bug fixed by bug 5864, this patch restore the
right way to search subscription (based on biblionumber).

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
C4/Serials.pm
catalogue/detail.pl
opac/opac-ISBDdetail.pl
opac/opac-detail.pl
serials/checkexpiration.pl
t/db_dependent/Serials.t