Bug 24777: Use patron.is_debarred instead of patron.debarred in return.tt
authorFridolin Somers <fridolin.somers@biblibre.com>
Mon, 2 Mar 2020 15:03:54 +0000 (18:03 +0300)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Tue, 10 Mar 2020 15:20:19 +0000 (15:20 +0000)
In return page return.tt, when there is an hold message, patron is said as restricted even if restriction end date is in the past.

Test plan :
1) For a patron Jon Doe create a manual restriction with end date in the past
2) Create an hold for this patron on an item
3) Check in this item => You don't see message "Patron is RESTRICTED"
4) For a patron Kevin Doe create a manual restriction with end date in the future
5) Create an hold for this patron on an item
6) Check in this item => You see message "Patron is RESTRICTED"
7) Repeate 1-6 with system preference HoldsAutoFill enabled
8) Repeate 1-6 with a waiting hold

Signed-off-by: Nazlı Çetin <nazli@devinim.com.tr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt

index 2981888..13dac5f 100644 (file)
@@ -89,7 +89,7 @@
                                             [% INCLUDE display_bormessagepref %]
                                         [% END %]
 
-                                        [% IF ( patron.debarred ) %]
+                                        [% IF ( patron.is_debarred ) %]
                                             <li class="error">Patron is RESTRICTED</li>
                                         [% END %]
 
                                                             <li><a id="boremail" href="mailto:[% patron.email | html %]">[% patron.email | html %]</a></li>
                                                         [% END %]
 
-                                                        [% IF ( patron.debarred ) %]
+                                                        [% IF ( patron.is_debarred ) %]
                                                             <li class="error">Patron is RESTRICTED</li>
                                                         [% END %]
 
                                                             [% INCLUDE display_bormessagepref %]
                                                         [% END %]
 
-                                                        [% IF ( patron.debarred ) %]
+                                                        [% IF ( patron.is_debarred ) %]
                                                             <li class="error">Patron is RESTRICTED</li>
                                                         [% END %]