Bug 22478: (QA follow-up) Handle category in opac-shelves like a boolean

The category parameter should be restricted to 1 or 2 (private/public). In
order to keep same behavior, no parameter means 1 (private).
Note: Adding the same line in intranet counterpart.

Test plan
[1] Check for category empty, '1a', '11' etc. And with script ;)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

diff --git a/opac/opac-shelves.pl b/opac/opac-shelves.pl
index d235292..f23778d 100755 (executable)
--- a/opac/opac-shelves.pl
+++ b/opac/opac-shelves.pl
@@ -60,6 +60,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user({
 my $op       = $query->param('op')       || 'list';
 my $referer  = $query->param('referer')  || $op;
 my $category = $query->param('category') || 1;
+$category = 2 if $category ne "1";
 my ( $shelf, $shelfnumber, @messages );
 
 if ( $op eq 'add_form' ) {

diff --git a/virtualshelves/shelves.pl b/virtualshelves/shelves.pl
index 097607c..3b59444 100755 (executable)
--- a/virtualshelves/shelves.pl
+++ b/virtualshelves/shelves.pl
@@ -51,6 +51,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
 my $op       = $query->param('op')       || 'list';
 my $referer  = $query->param('referer')  || $op;
 my $category = $query->param('category') || 1;
+$category = 2 if $category ne "1";
 my ( $shelf, $shelfnumber, @messages );
 
 if ( $op eq 'add_form' ) {