Bug 19677: Properly escape enumchrom/serialseq data
authorNick Clemens <nick@bywatersolutions.com>
Mon, 18 Dec 2017 14:42:25 +0000 (14:42 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 19 Jan 2018 18:46:43 +0000 (15:46 -0300)
Some serial issues use angle brackets for denoting certain data.
Currently this is not displayed in Koha. This patch escapes the data so
that angle brackets will display.

To test:
1 - Add an enumchron field to an item containg angle brackets:
"This is a <test>"
2 - View the record in the staff and opac, not the field displays as:
"This is a"
3 - Apply patch
4 - Note full text now displays

Signed-off-by: Charlotte Cordwell <charlotte.cordwell123@gmail.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt

index be5932b..c3d9df3 100644 (file)
                                     <span class="enum">[% item.enumchron %]</span>
                                     [% IF ( item.serialseq && item.enumchron!=item.serialseq ) %]
                                         <span class="sep"> -- </span>
-                                        <span class="serialseq">[% item.serialseq %]</span>
+                                        <span class="serialseq">[% item.serialseq | html %]</span>
                                     [% END %]
                                 [% ELSIF item.enumchron %]
-                                    <span class="enum">[% item.enumchron %]</span>
+                                    <span class="enum">[% item.enumchron | html %]</span>
                                 [% ELSIF item.serialseq %]
-                                    <span class="serialseq">[% item.serialseq %]</span>
+                                    <span class="serialseq">[% item.serialseq | html %]</span>
                                 [% END %]
                                 [% IF ( item.publisheddate ) %]
                                     <span class="pubdate">([% item.publisheddate | $KohaDates %])</span>
index ee9d411..270fc08 100644 (file)
                                 <span class="enum">[% ITEM_RESULT.enumchron %]</span>
                                 [% IF ( ITEM_RESULT.serialseq && ITEM_RESULT.enumchron!=ITEM_RESULT.serialseq ) %]
                                     <span class="sep"> -- </span>
-                                    <span class="serialseq">[% ITEM_RESULT.serialseq %]</span>
+                                    <span class="serialseq">[% ITEM_RESULT.serialseq | html %]</span>
                                 [% END %]
                             [% ELSIF ITEM_RESULT.enumchron %]
-                                <span class="enum">[% ITEM_RESULT.enumchron %]</span>
+                                <span class="enum">[% ITEM_RESULT.enumchron | html %]</span>
                             [% ELSIF ITEM_RESULT.serialseq %]
-                                    <span class="serialseq">[% ITEM_RESULT.serialseq %]</span>
+                                    <span class="serialseq">[% ITEM_RESULT.serialseq | html %]</span>
                             [% END %]
                             [% IF ( ITEM_RESULT.publisheddate ) %]
                                 <span class="pubdate">([% ITEM_RESULT.publisheddate | $KohaDates %])</span>