Bug 2505 - Add commented use warnings where missing in *.pm

diff --git a/C4/Accounts.pm b/C4/Accounts.pm
index bbc6c00..ff2188b 100644 (file)
--- a/C4/Accounts.pm
+++ b/C4/Accounts.pm
@@ -19,6 +19,7 @@ package C4::Accounts;
 
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::Stats;
 use C4::Members;

diff --git a/C4/Auth.pm b/C4/Auth.pm
index d745b63..94a05fb 100644 (file)
--- a/C4/Auth.pm
+++ b/C4/Auth.pm
@@ -18,6 +18,7 @@ package C4::Auth;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use Digest::MD5 qw(md5_base64);
 use Storable qw(thaw freeze);
 use URI::Escape;

diff --git a/C4/Auth_with_cas.pm b/C4/Auth_with_cas.pm
index 501fdef..8cf6b03 100644 (file)
--- a/C4/Auth_with_cas.pm
+++ b/C4/Auth_with_cas.pm
@@ -18,6 +18,7 @@ package C4::Auth_with_cas;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 use C4::Debug;
 use C4::Context;

diff --git a/C4/Auth_with_ldap.pm b/C4/Auth_with_ldap.pm
index 994f846..78666e9 100644 (file)
--- a/C4/Auth_with_ldap.pm
+++ b/C4/Auth_with_ldap.pm
@@ -18,7 +18,7 @@ package C4::Auth_with_ldap;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
-# use warnings; almost?
+#use warnings; FIXME - Bug 2505
 use Digest::MD5 qw(md5_base64);
 
 use C4::Debug;

diff --git a/C4/AuthoritiesMarc.pm b/C4/AuthoritiesMarc.pm
index f0f2d05..a3eef69 100644 (file)
--- a/C4/AuthoritiesMarc.pm
+++ b/C4/AuthoritiesMarc.pm
@@ -17,6 +17,7 @@ package C4::AuthoritiesMarc;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::Koha;
 use MARC::Record;

diff --git a/C4/AuthoritiesMarc/MARC21.pm b/C4/AuthoritiesMarc/MARC21.pm
index 1375369..dd3f0f8 100644 (file)
--- a/C4/AuthoritiesMarc/MARC21.pm
+++ b/C4/AuthoritiesMarc/MARC21.pm
@@ -18,6 +18,7 @@ package C4::AuthoritiesMarc::MARC21;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use MARC::Record;
 our $VERSION = 3.00;
 

diff --git a/C4/AuthoritiesMarc/UNIMARC.pm b/C4/AuthoritiesMarc/UNIMARC.pm
index 87f6743..5df70e6 100644 (file)
--- a/C4/AuthoritiesMarc/UNIMARC.pm
+++ b/C4/AuthoritiesMarc/UNIMARC.pm
@@ -18,6 +18,7 @@ package C4::AuthoritiesMarc::UNIMARC;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 our $VERSION = 3.00;
 
 =head1 NAME

diff --git a/C4/BackgroundJob.pm b/C4/BackgroundJob.pm
index 6d5bfea..e20eb6e 100644 (file)
--- a/C4/BackgroundJob.pm
+++ b/C4/BackgroundJob.pm
@@ -19,6 +19,7 @@ package C4::BackgroundJob;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::Auth qw/get_session/;
 use Digest::MD5;

diff --git a/C4/Barcodes/PrinterConfig.pm b/C4/Barcodes/PrinterConfig.pm
index d90cd96..183d4e4 100644 (file)
--- a/C4/Barcodes/PrinterConfig.pm
+++ b/C4/Barcodes/PrinterConfig.pm
@@ -16,6 +16,7 @@ package C4::Barcodes::PrinterConfig;
 # Suite 330, Boston, MA  02111-1307 USA
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use vars qw($VERSION @EXPORT);
 
 use PDF::API2;

diff --git a/C4/Bookseller.pm b/C4/Bookseller.pm
index 361039f..bdc4346 100644 (file)
--- a/C4/Bookseller.pm
+++ b/C4/Bookseller.pm
@@ -18,6 +18,7 @@ package C4::Bookseller;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 use vars qw($VERSION @ISA @EXPORT);
 

diff --git a/C4/Branch.pm b/C4/Branch.pm
index 103a14d..03d5824 100644 (file)
--- a/C4/Branch.pm
+++ b/C4/Branch.pm
@@ -17,6 +17,7 @@ package C4::Branch;
 
 
 use strict;
+#use warnings; FIXME - Bug 2505
 require Exporter;
 use C4::Context;
 use C4::Koha;

diff --git a/C4/Budgets.pm b/C4/Budgets.pm
index eb97615..eeb9b0c 100644 (file)
--- a/C4/Budgets.pm
+++ b/C4/Budgets.pm
@@ -18,6 +18,7 @@ package C4::Budgets;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::Dates qw(format_date format_date_in_iso);
 use C4::SQLHelper qw<:all>;

diff --git a/C4/Circulation.pm b/C4/Circulation.pm
index d780189..00b11ef 100644 (file)
--- a/C4/Circulation.pm
+++ b/C4/Circulation.pm
@@ -19,7 +19,7 @@ package C4::Circulation;
 
 
 use strict;
-#use warnings;  # soon!
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::Stats;
 use C4::Reserves;

diff --git a/C4/Contract.pm b/C4/Contract.pm
index 0f202c0..2fd54e7 100644 (file)
--- a/C4/Contract.pm
+++ b/C4/Contract.pm
@@ -18,6 +18,7 @@ package C4::Contract;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::SQLHelper qw(:all);
 
 use vars qw($VERSION @ISA @EXPORT);

diff --git a/C4/Csv.pm b/C4/Csv.pm
index 2ff1499..07ce2eb 100644 (file)
--- a/C4/Csv.pm
+++ b/C4/Csv.pm
@@ -19,6 +19,9 @@ package C4::Csv;
 #
 #
 
+#use strict;
+#use warnings; FIXME - Bug 2505
+
 use C4::Context;
 use vars qw($VERSION @ISA @EXPORT);
 

diff --git a/C4/Heading.pm b/C4/Heading.pm
index 0a23f94..ae1a0d0 100644 (file)
--- a/C4/Heading.pm
+++ b/C4/Heading.pm
@@ -18,6 +18,7 @@ package C4::Heading;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use MARC::Record;
 use MARC::Field;
 use C4::Context;

diff --git a/C4/Heading/MARC21.pm b/C4/Heading/MARC21.pm
index 1ff2c60..a057e51 100644 (file)
--- a/C4/Heading/MARC21.pm
+++ b/C4/Heading/MARC21.pm
@@ -18,6 +18,7 @@ package C4::Heading::MARC21;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use MARC::Record;
 use MARC::Field;
 

diff --git a/C4/Installer.pm b/C4/Installer.pm
index addb5c8..b3d798e 100644 (file)
--- a/C4/Installer.pm
+++ b/C4/Installer.pm
@@ -18,6 +18,7 @@ package C4::Installer;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 our $VERSION = 3.00;
 use C4::Context;

diff --git a/C4/Items.pm b/C4/Items.pm
index cd6f7d0..7f31cdc 100644 (file)
--- a/C4/Items.pm
+++ b/C4/Items.pm
@@ -18,6 +18,7 @@ package C4::Items;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 use Carp;
 use C4::Context;

diff --git a/C4/Koha.pm b/C4/Koha.pm
index cc72f35..11c7850 100644 (file)
--- a/C4/Koha.pm
+++ b/C4/Koha.pm
@@ -19,6 +19,7 @@ package C4::Koha;
 
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::Output;
 use URI::Split qw(uri_split);

diff --git a/C4/Languages.pm b/C4/Languages.pm
index 21dd6e8..9ef2439 100644 (file)
--- a/C4/Languages.pm
+++ b/C4/Languages.pm
@@ -20,7 +20,7 @@ package C4::Languages;
 
 
 use strict; 
-#use warnings;   #FIXME: turn off warnings before release
+#use warnings; FIXME - Bug 2505
 use Carp;
 use C4::Context;
 use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS $DEBUG);

diff --git a/C4/Maintainance.pm b/C4/Maintainance.pm
index 4a36353..33d6483 100644 (file)
--- a/C4/Maintainance.pm
+++ b/C4/Maintainance.pm
@@ -21,6 +21,7 @@ package C4::Maintainance; #assumes C4/Maintainance
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 
 require Exporter;

diff --git a/C4/Members.pm b/C4/Members.pm
index dfa41e5..4f79e3e 100644 (file)
--- a/C4/Members.pm
+++ b/C4/Members.pm
@@ -19,6 +19,7 @@ package C4::Members;
 
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::Dates qw(format_date_in_iso);
 use Digest::MD5 qw(md5_base64);

diff --git a/C4/Members/AttributeTypes.pm b/C4/Members/AttributeTypes.pm
index 389b148..0506e23 100644 (file)
--- a/C4/Members/AttributeTypes.pm
+++ b/C4/Members/AttributeTypes.pm
@@ -18,6 +18,7 @@ package C4::Members::AttributeTypes;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 
 use vars qw($VERSION);

diff --git a/C4/Output.pm b/C4/Output.pm
index 1c31558..61e79c6 100644 (file)
--- a/C4/Output.pm
+++ b/C4/Output.pm
@@ -26,6 +26,7 @@ package C4::Output;
 # templates.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 use C4::Context;
 use C4::Languages qw(getTranslatedLanguages get_bidi regex_lang_subtags language_get_description accept_language );

diff --git a/C4/Overdues.pm b/C4/Overdues.pm
index 5c9bde8..7f59b9b 100644 (file)
--- a/C4/Overdues.pm
+++ b/C4/Overdues.pm
@@ -19,6 +19,7 @@ package C4::Overdues;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use Date::Calc qw/Today Date_to_Days/;
 use Date::Manip qw/UnixDate/;
 use C4::Circulation;

diff --git a/C4/Print.pm b/C4/Print.pm
index 35bd8b5..674f220 100644 (file)
--- a/C4/Print.pm
+++ b/C4/Print.pm
@@ -18,6 +18,7 @@ package C4::Print;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::Circulation;
 use C4::Members;

diff --git a/C4/Record.pm b/C4/Record.pm
index 8dd073b..233fa6e 100644 (file)
--- a/C4/Record.pm
+++ b/C4/Record.pm
@@ -19,7 +19,8 @@ package C4::Record;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #
 #
-use strict;# use warnings; #FIXME: turn off warnings before release
+use strict;
+#use warnings; FIXME - Bug 2505
 
 # please specify in which methods a given module is used
 use MARC::Record; # marc2marcxml, marcxml2marc, html2marc, changeEncoding

diff --git a/C4/Reports.pm b/C4/Reports.pm
index 2777d0e..ab23f19 100644 (file)
--- a/C4/Reports.pm
+++ b/C4/Reports.pm
@@ -18,6 +18,7 @@ package C4::Reports;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use CGI;
 
 use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);

diff --git a/C4/Reports/Guided.pm b/C4/Reports/Guided.pm
index da34657..5cdad46 100644 (file)
--- a/C4/Reports/Guided.pm
+++ b/C4/Reports/Guided.pm
@@ -18,7 +18,7 @@ package C4::Reports::Guided;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
-# use warnings;  # FIXME: this module needs a lot of repair to run clean under warnings
+#use warnings; FIXME - Bug 2505 this module needs a lot of repair to run clean under warnings
 use CGI;
 use Carp;
 

diff --git a/C4/Reserves.pm b/C4/Reserves.pm
index fee4fce..464b3f3 100644 (file)
--- a/C4/Reserves.pm
+++ b/C4/Reserves.pm
@@ -21,7 +21,7 @@ package C4::Reserves;
 
 
 use strict;
-# use warnings;  # FIXME: someday
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::Biblio;
 use C4::Members;

diff --git a/C4/Ris.pm b/C4/Ris.pm
index d3026c0..c5c4806 100644 (file)
--- a/C4/Ris.pm
+++ b/C4/Ris.pm
@@ -57,6 +57,8 @@ package C4::Ris;
 #
 #
 
+#use strict;
+#use warnings; FIXME - Bug 2505
 
 use vars qw($VERSION @ISA @EXPORT);
 

diff --git a/C4/RotatingCollections.pm b/C4/RotatingCollections.pm
index 83fc6e0..6b1383f 100644 (file)
--- a/C4/RotatingCollections.pm
+++ b/C4/RotatingCollections.pm
@@ -23,6 +23,7 @@ package C4::RotatingCollections;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 require Exporter;
 

diff --git a/C4/Scheduler.pm b/C4/Scheduler.pm
index f4230a2..8cb6d19 100644 (file)
--- a/C4/Scheduler.pm
+++ b/C4/Scheduler.pm
@@ -18,6 +18,7 @@ package C4::Scheduler;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
 use C4::Context;

diff --git a/C4/Search.pm b/C4/Search.pm
index 554174c..7b0b408 100644 (file)
--- a/C4/Search.pm
+++ b/C4/Search.pm
@@ -16,7 +16,7 @@ package C4::Search;
 # Suite 330, Boston, MA  02111-1307 USA
 
 use strict;
-# use warnings; # FIXME
+#use warnings; FIXME - Bug 2505
 require Exporter;
 use C4::Context;
 use C4::Biblio;    # GetMarcFromKohaField, GetBiblioData

diff --git a/C4/Search/PazPar2.pm b/C4/Search/PazPar2.pm
index b12a2f7..bf786bc 100644 (file)
--- a/C4/Search/PazPar2.pm
+++ b/C4/Search/PazPar2.pm
@@ -18,6 +18,7 @@ package C4::Search::PazPar2;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 use LWP::UserAgent;
 use URI;

diff --git a/C4/Serials/Frequency.pm b/C4/Serials/Frequency.pm
index 9b1bc0f..e41db5e 100644 (file)
--- a/C4/Serials/Frequency.pm
+++ b/C4/Serials/Frequency.pm
@@ -18,6 +18,7 @@ package C4::Frequency;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::SQLHelper qw<:all>;
 use C4::Debug;

diff --git a/C4/Serials/NumberPattern.pm b/C4/Serials/NumberPattern.pm
index 9425d3e..88e6def 100644 (file)
--- a/C4/Serials/NumberPattern.pm
+++ b/C4/Serials/NumberPattern.pm
@@ -18,6 +18,7 @@ package C4::Numberpattern;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::SQLHelper qw<:all>;
 use C4::Debug;

diff --git a/C4/Suggestions.pm b/C4/Suggestions.pm
index 2f7bd07..7c283f1 100644 (file)
--- a/C4/Suggestions.pm
+++ b/C4/Suggestions.pm
@@ -19,6 +19,7 @@ package C4::Suggestions;
 
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use CGI;
 
 use C4::Context;

diff --git a/C4/UploadedFile.pm b/C4/UploadedFile.pm
index 11fdef3..3329936 100644 (file)
--- a/C4/UploadedFile.pm
+++ b/C4/UploadedFile.pm
@@ -19,6 +19,7 @@ package C4::UploadedFile;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::Auth qw/get_session/;
 use IO::File;

diff --git a/C4/XISBN.pm b/C4/XISBN.pm
index 8175e08..aa9687c 100644 (file)
--- a/C4/XISBN.pm
+++ b/C4/XISBN.pm
@@ -27,6 +27,7 @@ use LWP::UserAgent;
 use HTTP::Request::Common;
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
 
 BEGIN {

diff --git a/C4/Z3950.pm b/C4/Z3950.pm
index c0d7fe0..2ac1460 100644 (file)
--- a/C4/Z3950.pm
+++ b/C4/Z3950.pm
@@ -25,6 +25,7 @@ package C4::Z3950;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 # standard or CPAN modules used
 use DBI;

diff --git a/install_misc/UpgradeBackup.pm b/install_misc/UpgradeBackup.pm
index 5aaf929..f84f338 100644 (file)
--- a/install_misc/UpgradeBackup.pm
+++ b/install_misc/UpgradeBackup.pm
@@ -18,6 +18,7 @@ package install_misc::UpgradeBackup;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use File::Compare qw(compare);
 use Cwd qw(cwd);
 use File::Copy;

diff --git a/installer/InstallAuth.pm b/installer/InstallAuth.pm
index 4d56596..3a55b21 100644 (file)
--- a/installer/InstallAuth.pm
+++ b/installer/InstallAuth.pm
@@ -21,6 +21,7 @@ package InstallAuth;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use Digest::MD5 qw(md5_base64);
 
 require Exporter;

diff --git a/misc/translator/TmplToken.pm b/misc/translator/TmplToken.pm
index 0a54d0b..cb883b4 100644 (file)
--- a/misc/translator/TmplToken.pm
+++ b/misc/translator/TmplToken.pm
@@ -1,6 +1,7 @@
 package TmplToken;
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use TmplTokenType;
 require Exporter;
 

diff --git a/misc/translator/TmplTokenType.pm b/misc/translator/TmplTokenType.pm
index 75d4f52..217cfbb 100644 (file)
--- a/misc/translator/TmplTokenType.pm
+++ b/misc/translator/TmplTokenType.pm
@@ -1,6 +1,7 @@
 package TmplTokenType;
 
 use strict;
+#use warnings; FIXME - Bug 2505
 require Exporter;
 
 use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);

diff --git a/misc/translator/TmplTokenizer.pm b/misc/translator/TmplTokenizer.pm
index 919a5d4..838a59f 100644 (file)
--- a/misc/translator/TmplTokenizer.pm
+++ b/misc/translator/TmplTokenizer.pm
@@ -1,6 +1,7 @@
 package TmplTokenizer;
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use TmplTokenType;
 use TmplToken;
 use VerboseWarnings qw( pedantic_p error_normal warn_normal warn_pedantic );

diff --git a/misc/translator/VerboseWarnings.pm b/misc/translator/VerboseWarnings.pm
index 05fd9e5..e2d57dd 100644 (file)
--- a/misc/translator/VerboseWarnings.pm
+++ b/misc/translator/VerboseWarnings.pm
@@ -1,6 +1,7 @@
 package VerboseWarnings;
 
 use strict;
+#use warnings; FIXME - Bug 2505
 require Exporter;
 
 use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);