Bug 16420: Buttons inconsistent between "Hold found" and "Hold found (waiting)" dialo...
authorOwen Leonard <oleonard@myacpl.org>
Fri, 5 Oct 2018 17:05:19 +0000 (17:05 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Tue, 9 Oct 2018 15:02:46 +0000 (15:02 +0000)
This patch makes minor changes to the text of hold confirmation buttons
in the checkin process in order to make them more consistent.

Also changed: Removed the "danger" class from the "Ignore" button for
readability and consistency's sake.

To test, apply the patch and check in an item which is on hold for a
patron at your logged-in library. The hold confirmation dialog's buttons
should read "Confirm hold," "Print slip and confirm," and "Ignore."

Confirm the hold, then check in the same item again.

In the dialog, the buttons should read "Confirm hold," "Print slip and
confirm," and "Cancel hold."

Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt

index 0bfc871..5763e97 100644 (file)
                     <input type="hidden" name="cancel_reserve" value="0" />
 
                     <button type="submit" class="btn btn-default approve" data-dismiss="modal">
-                        <i class="fa fa-check"></i> Confirm
+                        <i class="fa fa-check"></i> Confirm hold
                     </button>
 
                     <input type="hidden" name="print_slip" value="0" />
                     <button type="submit" class="btn btn-default print" onclick="this.form.print_slip.value = 1; this.form.submit();">
-                        <i class="fa fa-print"></i> Print and confirm
+                        <i class="fa fa-print"></i> Print slip and confirm
                     </button>
 
                     <button type="submit" class="btn btn-default deny" onclick="this.form.cancel_reserve.value = 1; this.form.submit();">
                         </button>
                     [% END %]
 
-                    <button data-dismiss="modal" aria-hidden="true" type="submit" class="btn btn-danger deny" onclick="$('#barcode').focus(); return false;">
+                    <button data-dismiss="modal" aria-hidden="true" type="submit" class="btn btn-default deny" onclick="$('#barcode').focus(); return false;">
                         <i class="fa fa-times"></i> Ignore
                     </button>
                 </div>