Bug 13897: Surround columns with backticks

We have some column's names that need to be surrounded by ` as they are
protected keywords ('rows' for instance)

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

diff --git a/C4/Installer.pm b/C4/Installer.pm
index 2e09627..012bc1c 100644 (file)
--- a/C4/Installer.pm
+++ b/C4/Installer.pm
@@ -486,7 +486,7 @@ sub load_sql {
                     my $table_name   = ( keys %$table )[0];                          # table name
                     my @rows         = @{ $table->{$table_name}->{rows} };           #
                     my @columns      = ( sort keys %{$rows[0]} );                    # column names
-                    my $fields       = join ",", @columns;                           # idem, joined
+                    my $fields       = join ",", map{sprintf("`%s`", $_)} @columns;  # idem, joined
                     my $placeholders = join ",", map { "?" } @columns;               # '?,..,?' string
                     my $query        = "INSERT INTO $table_name ( $fields ) VALUES ( $placeholders )";
                     my $sth          = $dbh->prepare($query);