Bug 21395: Make perlcritic happy

[koha.git] / reports / bor_issues_top.pl

diff --git a/reports/bor_issues_top.pl b/reports/bor_issues_top.pl
index 84a46a3..e2f6989 100755 (executable)
--- a/reports/bor_issues_top.pl
+++ b/reports/bor_issues_top.pl
@@ -41,7 +41,7 @@ plugin that shows a stats on borrowers
 
 =cut
 
-$debug and open DEBUG, ">/tmp/bor_issues_top.debug.log";
+$debug and open my $debugfh, '>', '/tmp/bor_issues_top.debug.log';
 
 my $input = new CGI;
 my $fullreportname = "reports/bor_issues_top.tt";
@@ -104,7 +104,6 @@ if ($do_it) {
 }
 
 my $dbh = C4::Context->dbh;
-my @values;
 
 # here each element returned by map is a hashref, get it?
 my @mime  = ( map { {type =>$_} } (split /[;:]/, 'CSV') ); # FIXME translation
@@ -125,7 +124,6 @@ sub calculate {
     my ($limit, $column, $filters) = @_;
 
     my @loopcol;
-    my @loopline;
     my @looprow;
     my %globalline;
        my %columns;
@@ -226,25 +224,25 @@ sub calculate {
         $strsth2 .=" GROUP BY $colfield";
         $strsth2 .=" ORDER BY $colorder";
 
-        $debug and print DEBUG "bor_issues_top (old_issues) SQL: $strsth2\n";
+        $debug and print $debugfh "bor_issues_top (old_issues) SQL: $strsth2\n";
         my $sth2 = $dbh->prepare($strsth2);
         $sth2->execute;
-        print DEBUG "rows: ", $sth2->rows, "\n";
+        print $debugfh "rows: ", $sth2->rows, "\n";
         while (my @row = $sth2->fetchrow) {
                        $columns{($row[0] ||'NULL')}++;
             push @loopcol, { coltitle => $row[0] || 'NULL' };
         }
 
                $strsth2 =~ s/old_issues/issues/g;
-        $debug and print DEBUG "bor_issues_top (issues) SQL: $strsth2\n";
+        $debug and print $debugfh "bor_issues_top (issues) SQL: $strsth2\n";
                $sth2 = $dbh->prepare($strsth2);
         $sth2->execute;
-        $debug and print DEBUG "rows: ", $sth2->rows, "\n";
+        $debug and print $debugfh "rows: ", $sth2->rows, "\n";
         while (my @row = $sth2->fetchrow) {
                        $columns{($row[0] ||'NULL')}++;
             push @loopcol, { coltitle => $row[0] || 'NULL' };
         }
-               $debug and print DEBUG "full array: ", Dumper(\%columns), "\n";
+               $debug and print $debugfh "full array: ", Dumper(\%columns), "\n";
     }else{
         $columns{''} = 1;
     }
@@ -281,10 +279,10 @@ sub calculate {
     $strcalc .= ",$colfield " if ($colfield);
     $strcalc .= " LIMIT $limit" if ($limit);
 
-    $debug and print DEBUG "(old_issues) SQL : $strcalc\n";
+    $debug and print $debugfh "(old_issues) SQL : $strcalc\n";
     my $dbcalc = $dbh->prepare($strcalc);
     $dbcalc->execute;
-    $debug and print DEBUG "rows: ", $dbcalc->rows, "\n";
+    $debug and print $debugfh "rows: ", $dbcalc->rows, "\n";
        my %patrons = ();
        # DATA STRUCTURE is going to look like this:
        #       (2253=> {name=>"John Doe",
@@ -303,10 +301,10 @@ sub calculate {
        use Data::Dumper;
 
        $strcalc =~ s/old_issues/issues/g;
-    $debug and print DEBUG "(issues) SQL : $strcalc\n";
+    $debug and print $debugfh "(issues) SQL : $strcalc\n";
     $dbcalc = $dbh->prepare($strcalc);
     $dbcalc->execute;
-    $debug and print DEBUG "rows: ", $dbcalc->rows, "\n";
+    $debug and print $debugfh "rows: ", $dbcalc->rows, "\n";
     while (my @data = $dbcalc->fetchrow) {
         my ($row, $rank, $id, $col) = @data;
         $col = "zzEMPTY" if (!defined($col));
@@ -325,7 +323,7 @@ sub calculate {
                        $patrons{$id}->{total} += $count;
                }
        }
-    $debug and print DEBUG "\n\npatrons: ", Dumper(\%patrons);
+    $debug and print $debugfh "\n\npatrons: ", Dumper(\%patrons);
     
        my $i = 1;
        my @cols_in_order = sort keys %columns;         # if you want to order the columns, do something here
@@ -371,6 +369,6 @@ sub calculate {
     return [\%globalline];     # reference to a 1 element array: that element is a hashref
 }
 
-$debug and close DEBUG;
+$debug and close $debugfh;
 1;
 __END__