From 5cb143f1fc584a55e4732dbc747c875367baa241 Mon Sep 17 00:00:00 2001 From: Shawn Boyette Date: Wed, 6 May 2009 20:59:12 +0000 Subject: [PATCH 1/1] fixes --- .../lib/Equinox/Migration/MARCXMLSampler.pm | 11 +++---- .../lib/Equinox/Migration/MapDrivenMARCXMLProc.pm | 30 ++++++++++++++++++-- 2 files changed, 32 insertions(+), 9 deletions(-) diff --git a/Equinox-Migration/lib/Equinox/Migration/MARCXMLSampler.pm b/Equinox-Migration/lib/Equinox/Migration/MARCXMLSampler.pm index 3ec869f..e4243e6 100644 --- a/Equinox-Migration/lib/Equinox/Migration/MARCXMLSampler.pm +++ b/Equinox-Migration/lib/Equinox/Migration/MARCXMLSampler.pm @@ -72,9 +72,7 @@ sub new { die "Argument 'marcfile' must be specified\n" unless ($args{marcfile}); if (-r $args{marcfile}) { $self->{twig} = XML::Twig->new; - $self->{twig}->parsefile($args{marcfile}); - my @records = $self->{twig}->root->children; - $self->{data}{recs} = \@records; + $self->{conf}{marc} = $args{marcfile}; } else { die "Can't open marc file: $!\n"; } @@ -100,10 +98,11 @@ Extracts data from MARC records, per the mapping file. sub parse_records { my ($self) = @_; - for my $record ( @{$self->{data}{recs}} ) { + $self->{twig}->parsefile( $self->{conf}{marc} ); + for my $record ( $self->{twig}->root->children ) { my @fields = $record->children; for my $f (@fields) - { $self->process_field($f) } + { $self->process_field($f); $f->purge } # cleanup memory and increment pointer $record->purge; @@ -124,7 +123,7 @@ sub process_field { if ($map and $map->has($tag)) { my @subs = $field->children('subfield'); for my $sub (@subs) - { $self->process_subs($tag, $sub) } + { $self->process_subs($tag, $sub); $sub->purge } } } diff --git a/Equinox-Migration/lib/Equinox/Migration/MapDrivenMARCXMLProc.pm b/Equinox-Migration/lib/Equinox/Migration/MapDrivenMARCXMLProc.pm index b55fdc4..190125d 100644 --- a/Equinox-Migration/lib/Equinox/Migration/MapDrivenMARCXMLProc.pm +++ b/Equinox-Migration/lib/Equinox/Migration/MapDrivenMARCXMLProc.pm @@ -98,7 +98,7 @@ sub parse_record { my @fields = $record->children; for my $f (@fields) - { $self->process_field($f) } + { $self->process_field($f); $f->purge; } # cleanup memory and increment pointer $record->purge; @@ -133,14 +133,19 @@ sub process_field { push @{$crec->{tmap}{$tag}}, (@{$crec->{tags}} - 1); my @subs = $field->children('subfield'); for my $sub (@subs) - { $self->process_subs($tag, $sub) } - # check map to ensure all declared subs have a value + { $self->process_subs($tag, $sub); $sub->purge; } + + # check map to ensure all declared tags and subs have a value my $mods = $map->mods($field); for my $mappedsub ( @{ $map->subfields($tag) } ) { next if $mods->{multi}; $crec->{tags}[-1]{uni}{$mappedsub} = '' unless defined $crec->{tags}[-1]{uni}{$mappedsub}; } + for my $mappedtag ( @{ $map->tags }) { + $crec->{tmap}{$mappedtag} = undef + unless defined $crec->{tmap}{$mappedtag}; + } } } @@ -155,6 +160,7 @@ sub process_subs { # fetch our datafield struct and fieldname my $dataf = $self->{data}{crec}{tags}[-1]; my $field = $map->field($tag, $code); + $self->{data}{crec}{names}{$tag}{$code} = $field; # test filters for my $filter ( @{$map->filters($field)} ) { @@ -199,6 +205,24 @@ sub check_required { } +=head2 recno + +Returns current record number (starting from zero) + +=cut + +sub recno { my ($self) = @_; return $self->{data}{rptr} } + +=head2 name + +Returns mapped fieldname when pass a tag and code + + my $name = $m->name(999,'a'); + +=cut + +sub name { my ($self, $t, $c) = @_; return $self->{data}{crec}{names}{$t}{$c} }; + =head1 MODIFIERS MapDrivenMARCXMLProc implements the following modifiers, and passes -- 1.7.2.5