Acq: Fix General Search for Lineitem Attribute-based fields
authorLebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Thu, 30 Aug 2012 16:20:13 +0000 (12:20 -0400)
committerBill Erickson <berick@esilibrary.com>
Thu, 30 Aug 2012 16:36:28 +0000 (12:36 -0400)
Reported by Ben Shum and Kathy Lussier, the Acq General Search interface
was broken in that you couldn't use any of the search fields under
Lineitem Attribute.  This error was indeed introduced by recent commit
55a82b5 as Ben determined, but simply reverting that commit left other
things broken.

This commit actually targets the problem and seems to fix it in my
testing.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Open-ILS/web/js/ui/default/acq/search/unified.js

index 6f6142f..c0a1fa9 100644 (file)
@@ -129,7 +129,13 @@ function TermSelectorFactory(terms) {
         ) {
             var term = this.getTerm();
             var widgetKey = this.uniq;
-            var target = termManager.getLinkTarget(term);
+            var target;
+            try {
+                target = termManager.getLinkTarget(term);
+            } catch (E) {
+                void(0); /* ok for this to fail (it doesn't handle acqlia right,
+                            but we don't need it to in this case). */
+            };
 
             if (matchHow.getValue() == "__in") {
                 new openils.widget.XULTermLoader({