LP1864056: Don't compare multiple new Date()s
authorJason Boyer <JBoyer@eoli.info>
Fri, 21 Feb 2020 21:08:36 +0000 (16:08 -0500)
committerJane Sandberg <sandbej@linnbenton.edu>
Sun, 12 Jul 2020 15:31:17 +0000 (08:31 -0700)
commit109add76520e7c2dbd2530700f91d3d7e5797e23
tree0bb63abb3a91e7c46fb8cdd4bae61c331302b12b
parentce7970d35f44930f5126591aee1f3d9673037fc1
LP1864056: Don't compare multiple new Date()s

This branch addresses a race condition when
checking out or renewing items.
(The use of minDate in items_out was implicitly
immune to this issue, but that is made explicit
with this patch.)

To test
-------
[1] The race condition would be difficult to reliably
    reproduce directly, although a tool like
    https://github.com/mattzeunert/javascript-clock-speedup
    might help simulate the problem, so to test, verify
    that the following actions do not break:

    * checking out a loan, both with and without
      setting a specific due date
    * renewing a loan with a specific due date
      from the patron items out tab
    * renewing a loan from Circulation -> Renew Items,
      both with and without setting a specific due date.

Signed-off-by: Jason Boyer <JBoyer@eoli.info>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Open-ILS/web/js/ui/default/staff/circ/patron/checkout.js
Open-ILS/web/js/ui/default/staff/circ/patron/items_out.js
Open-ILS/web/js/ui/default/staff/circ/renew/app.js