LP1895660: Course.pm
authorJason Boyer <JBoyer@equinoxinitiative.org>
Tue, 15 Sep 2020 13:28:57 +0000 (09:28 -0400)
committerGalen Charlton <gmc@equinoxOLI.org>
Fri, 14 May 2021 21:38:04 +0000 (17:38 -0400)
"my" variable $results masks earlier declaration in same scope

my $var should only be used once within a block.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Course.pm

index 46c4521..260221f 100644 (file)
@@ -302,7 +302,7 @@ sub load_cresults {
         "where" => $where_clause
     });
 
-    my $results = $e->json_query({
+    $results = $e->json_query({
         "from" => "acmc",
         "select" => {"acmc" => [
             'id',