LP1474874: Consistent page headers in the Angular client

This commit ensures that each screen in the Angular staff client uses
the <eg-staff-banner> component to better orient its users.

This commit also gives the eg-staff-banner some <h1> semantics, per
WebAIM's guidance: "Pages should be structured in a hierarchical manner,
generally with one 1st degree headings (<h1>) being the most important
(usually page titles or main content heading)" -- https://webaim.org/techniques/semanticstructure/

To test:

1) Go to [your-server]/eg2/en-US/staff/catalog/search
2) Confirm that there is a header that gives the page title at the top
of the page.
3) Go to an Angular Vandelay page.
4) Confirm that you see a similar header as in step 2.
5) Go to an Angular Administration page.
6) repeat step 4.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>

diff --git a/Open-ILS/src/eg2/src/app/staff/cat/vandelay/vandelay.component.html b/Open-ILS/src/eg2/src/app/staff/cat/vandelay/vandelay.component.html
index a81472d..1a48cac 100644 (file)
--- a/Open-ILS/src/eg2/src/app/staff/cat/vandelay/vandelay.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/cat/vandelay/vandelay.component.html
@@ -1,4 +1,5 @@
-
+<eg-staff-banner bannerText="MARC Batch Import/Export" i18n-bannerText>
+</eg-staff-banner>
 <ul class="nav nav-pills nav-fill pb-4">
   <li class="nav-item">
     <a class="nav-link" [ngClass]="{active: tab=='export'}" 

diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/browse.component.html b/Open-ILS/src/eg2/src/app/staff/catalog/browse.component.html
index 175104b..00a3f92 100644 (file)
--- a/Open-ILS/src/eg2/src/app/staff/catalog/browse.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/catalog/browse.component.html
@@ -1,3 +1,5 @@
+<eg-staff-banner bannerText="Staff Catalog (Experimental)" i18n-bannerText>
+</eg-staff-banner>
 
 <eg-catalog-search-form #searchForm></eg-catalog-search-form>
 

diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/catalog.component.html b/Open-ILS/src/eg2/src/app/staff/catalog/catalog.component.html
index 1596454..af1d604 100644 (file)
--- a/Open-ILS/src/eg2/src/app/staff/catalog/catalog.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/catalog/catalog.component.html
@@ -1,3 +1,5 @@
+<eg-staff-banner bannerText="Staff Catalog (Experimental)" i18n-bannerText>
+</eg-staff-banner>
 <!-- search form sits atop every catalog page -->
 <eg-catalog-search-form></eg-catalog-search-form>
 

diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/cnbrowse.component.html b/Open-ILS/src/eg2/src/app/staff/catalog/cnbrowse.component.html
index 9be00ff..eca35ca 100644 (file)
--- a/Open-ILS/src/eg2/src/app/staff/catalog/cnbrowse.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/catalog/cnbrowse.component.html
@@ -1,3 +1,5 @@
+<eg-staff-banner bannerText="Staff Catalog (Experimental)" i18n-bannerText>
+</eg-staff-banner>
 
 <eg-catalog-search-form #searchForm></eg-catalog-search-form>
 

diff --git a/Open-ILS/src/eg2/src/app/staff/share/staff-banner.component.ts b/Open-ILS/src/eg2/src/app/staff/share/staff-banner.component.ts
index 1274086..a45e276 100644 (file)
--- a/Open-ILS/src/eg2/src/app/staff/share/staff-banner.component.ts
+++ b/Open-ILS/src/eg2/src/app/staff/share/staff-banner.component.ts
@@ -3,7 +3,7 @@ import {Component, OnInit, Input} from '@angular/core';
 @Component({
   selector: 'eg-staff-banner',
   template: `
-    <div class="lead alert alert-primary text-center pt-1 pb-1" role="alert">
+    <div class="lead alert alert-primary text-center pt-1 pb-1">
       <eg-title i18n-prefix [prefix]="bannerText"></eg-title>
        <span>{{bannerText}}</span>
     </div>