Patch from Thomas Berezansky to do the following:

    Add more "click to copy" fields

    User's Name
    All three phone numbers

    Also fix issue where tooltip didn't clear when re-opening search form

    Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20427 dcc99617-32d9-48b4-a31d-7c20da2025e4

diff --git a/Open-ILS/xul/staff_client/server/patron/display.js b/Open-ILS/xul/staff_client/server/patron/display.js
index ba9956e..0f7f9ac 100644 (file)
--- a/Open-ILS/xul/staff_client/server/patron/display.js
+++ b/Open-ILS/xul/staff_client/server/patron/display.js
@@ -137,6 +137,8 @@ patron.display.prototype = {
                             obj.controller.view.cmd_search_form.setAttribute('disabled','true');
                             obj.left_deck.node.selectedIndex = 0;
                             obj.controller.view.patron_name.setAttribute('value', $("patronStrings").getString('staff.patron.display.cmd_search_form.no_patron'));
+                            obj.controller.view.patron_name.setAttribute('tooltiptext', '');
+                            obj.controller.view.patron_name.setAttribute('onclick', '');
                             removeCSSClass(document.documentElement,'PATRON_HAS_BILLS');
                             removeCSSClass(document.documentElement,'PATRON_HAS_OVERDUES');
                             removeCSSClass(document.documentElement,'PATRON_HAS_NOTES');
@@ -516,6 +518,7 @@ patron.display.prototype = {
                                     ]
                                 );
                                 e.setAttribute('tooltiptext',tooltiptext);
+                                e.setAttribute('onclick','try { copy_to_clipboard(event); } catch(E) { alert(E); }');
                             };
                         }
                     ],

diff --git a/Open-ILS/xul/staff_client/server/patron/summary_overlay.xul b/Open-ILS/xul/staff_client/server/patron/summary_overlay.xul
index 0c540e1..a0d7deb 100644 (file)
--- a/Open-ILS/xul/staff_client/server/patron/summary_overlay.xul
+++ b/Open-ILS/xul/staff_client/server/patron/summary_overlay.xul
@@ -170,17 +170,17 @@
         <row id="pdcgpr1">
             <label id="PatronSummaryContact_day_phone_label" class="copyable text_left phone label day_phone"
                 value="&staff.patron_display.day_phone.label;" />
-            <description id="patron_day_phone" class="copyable phone value day_phone"/> 
+            <description id="patron_day_phone" class="copyable phone value day_phone click_link" onclick="try { copy_to_clipboard(event); } catch(E) { alert(E); }"/> 
         </row>
         <row id="pdcgpr2">
             <label id="PatronSummaryContact_evening_phone_label" class="copyable text_left phone label evening_phone"
                 value="&staff.patron_display.evening_phone.label;" />
-            <description id="patron_evening_phone" class="copyable phone value evening_phone"/>
+            <description id="patron_evening_phone" class="copyable phone value evening_phone click_link" onclick="try { copy_to_clipboard(event); } catch(E) { alert(E); }"/>
         </row>
         <row id="pdcgpr3">
             <label id="PatronSummaryContact_other_phone_label" class="copyable text_left phone label other_phone"
                 value="&staff.patron_display.other_phone.label;" />
-            <description id="patron_other_phone" class="copyable phone value other_phone"/> 
+            <description id="patron_other_phone" class="copyable phone value other_phone click_link" onclick="try { copy_to_clipboard(event); } catch(E) { alert(E); }"/> 
         </row>
         <row id="pdsgpr4"><label id="pdsgpr4l" value=" "/></row>
         <row id="pdsgpr4a">

diff --git a/Open-ILS/xul/staff_client/server/patron/summary_overlay_horiz.xul b/Open-ILS/xul/staff_client/server/patron/summary_overlay_horiz.xul
index 5b2e9c2..3687fff 100644 (file)
--- a/Open-ILS/xul/staff_client/server/patron/summary_overlay_horiz.xul
+++ b/Open-ILS/xul/staff_client/server/patron/summary_overlay_horiz.xul
@@ -230,17 +230,17 @@
                 <row id="pdcgpr1">
                     <label id="PatronSummaryContact_day_phone_label" class="copyable text_left phone label day_phone"
                         value="&staff.patron_display.day_phone.label;" />
-                    <description id="patron_day_phone" class="copyable phone value day_phone"/> 
+                    <description id="patron_day_phone" class="copyable phone value day_phone click_link" onclick="try { copy_to_clipboard(event); } catch(E) { alert(E); }"/> 
                 </row>
                 <row id="pdcgpr2">
                     <label id="PatronSummaryContact_evening_phone_label" class="copyable text_left phone label evening_phone"
                         value="&staff.patron_display.evening_phone.label;" />
-                    <description id="patron_evening_phone" class="copyable phone value evening_phone"/>
+                    <description id="patron_evening_phone" class="copyable phone value evening_phone click_link" onclick="try { copy_to_clipboard(event); } catch(E) { alert(E); }"/>
                 </row>
                 <row id="pdcgpr3">
                     <label id="PatronSummaryContact_other_phone_label" class="copyable text_left phone label other_phone"
                         value="&staff.patron_display.other_phone.label;" />
-                    <description id="patron_other_phone" class="copyable phone value other_phone"/> 
+                    <description id="patron_other_phone" class="copyable phone value other_phone click_link" onclick="try { copy_to_clipboard(event); } catch(E) { alert(E); }"/> 
                 </row>
             </rows>
         </grid>