check user 'active' field in SIP charge_ok (and dependent) calls

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20268 dcc99617-32d9-48b4-a31d-7c20da2025e4

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
index 607dce7..c628820 100644 (file)
--- a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
@@ -269,7 +269,10 @@ sub language {
 sub charge_ok {
     my $self = shift;
     my $u = $self->{user};
-    return (($u->barred eq 'f') and ($u->card->active eq 't'));
+    return 
+        $u->barred eq 'f' and 
+        $u->active eq 't' and
+        $u->card->active eq 't';
 }
 
 # How much more detail do we need to check here?