newline at end of sample run

[migration-tools.git] / extract_holdings

diff --git a/extract_holdings b/extract_holdings
index 0557416..117aef5 100755 (executable)
--- a/extract_holdings
+++ b/extract_holdings
@@ -22,6 +22,7 @@ $| = 1;
 # run samples if we've been asked for them
 run_samples($c) if ($c->{sample} or $c->{samplemap} or $c->{samplestr});
 extract_holdings($c) if ($c->{map});
+print "\n";
 
 #--------------------------
 
@@ -36,20 +37,25 @@ sub extract_holdings {
     # open main holdings file
     open HOLDINGS, '>', ($c->{prefix} . "-HOLDINGS.pg");
     # create multi files
-    my @multifiles = <*HOLDINGS-MULT*>;
-    unlink @multifiles;
+    my $multis = $m->get_multis;
+    my %MULTIFILE = ();
+    for my $t ( keys %{$multis} ) {
+        for my $s ( keys %{$multis->{$t}}) 
+          { open my $fh, ">", ($c->{prefix} . "-HOLDINGS-MULT-$t$s.pg"); $MULTIFILE{"$t$s"} = $fh }
+    }
 
     my $i = 0; # record counter
     my $j = 0; # holdings counter
-    my $multis = $m->get_multis;
 
     while (  $m->{data}{recs}[$i] ) {
-        print HOLDINGS "BEGIN;\n\negid\thseq\t" unless $j;
+        print HOLDINGS "BEGIN;\n\negid, hseq, " unless $j;
         my $rec = $m->{data}{recs}[$i];
-
+        my $k = 0; # holding-within-record pointer
         # for each holdings tag in the record...
-        for my $holdidx ( @{$rec->{tmap}{ $c->{holdings} }} ) {
+        while ( defined $rec->{tmap}{ $c->{holdings} }[$k] ) {
+            my $holdidx = $rec->{tmap}{ $c->{holdings} }[$k];
             my $tagid = $rec->{tags}[$holdidx]{tag};
+            $k++;
 
             my @out = ();            # clear the output buffer
             push @out, $rec->{egid}; # slug in the egid first thing
@@ -58,15 +64,15 @@ sub extract_holdings {
             # grab the unary mappings and slug 'em in
             for my $sub ( sort keys %{$rec->{tags}[$holdidx]{uni}} ) {
                 push @out, $rec->{tags}[$holdidx]{uni}{$sub};
-                print HOLDINGS "l_", $m->name($tagid, $sub),"\t" unless $j;
+                print HOLDINGS "l_", $m->name($tagid, $sub),", " unless $j;
             }
 
             # handle holdings multis
             for my $sub ( sort keys %{$multis->{$tagid}} ) {
-                open MULT, ">>", ($c->{prefix} . "HOLDINGS-MULT" . "$tagid$sub.pg");
-                for my $value ( @{$rec->{tags}[$holdidx]{multi}{$sub}} ) 
-                  { print MULT join("\t", $rec->{egid}, $j, $value), "\n" }
-                close MULT;
+                for my $value ( @{$rec->{tags}[$holdidx]{multi}{$sub}} ) {
+                  my $fh = $MULTIFILE{"$tagid$sub"};
+                  print $fh join("\t", $rec->{egid}, $j, $value), "\n";
+              }
             }
 
 
@@ -76,7 +82,7 @@ sub extract_holdings {
                 my $idx = $rec->{tmap}{$othertag}[0]; # get index into tags struct
                 for my $sub ( sort keys %{$rec->{tags}[$idx]{uni}} ) {
                     push @out, $rec->{tags}[$idx]{uni}{$sub};
-                    print "l_", $m->name($rec->{tags}[$idx]{tag}, $sub), "\t"
+                    print HOLDINGS "l_", $m->name($rec->{tags}[$idx]{tag}, $sub), ", "
                       unless $j;
                 }
             }
@@ -86,6 +92,8 @@ sub extract_holdings {
             print HOLDINGS join("\t", @out);
             print HOLDINGS "\n";
             $j++;
+
+            @out = undef;
         }
         $i++;
         print "\r$i";
@@ -182,8 +190,8 @@ sub initialize {
                          'sample|s',
                          'samplemap|sm=s',
                          'samplestr|ss=s',
-                         'marcfile|m=s',
-                         'map=s',
+                         'marcfile=s',
+                         'map|m=s',
                          'holdings|h=i',
                          'copyid|c=s',
                          'prefix|p=s',
@@ -198,6 +206,10 @@ sub initialize {
       if ($c->{map} and !($c->{holdings} and $c->{copyid}));
     show_version() if $c->{version};
 
+    if ($c->{prefix} and !$c->{marcfile}) {
+        $c->{marcfile} = $c->{prefix} . ".clean.marc.xml";
+    }
+
     my @keys = keys %{$c};
     for my $key ('prefix', 'marcfile')
       { push @missing, $key unless $c->{$key} }
@@ -218,7 +230,8 @@ Usage is: extract_holdings -p PREFIX -m MARCFILE [ARGUMENTS]
 
 REQUIRED ARGUMENTS
   --prefix   -p  Prefix string for output filenames
-  --marcfile -m  MARCXML to use as source data
+  --marcfile     MARCXML to use as source data
+                 Defaults to 'PREFIX.clean.marc.xml'
 
 SAMPLING ARGUMENTS
   --sample    -s   Generate a report of all tags in the MARC data
@@ -231,7 +244,7 @@ SAMPLING ARGUMENTS
   If --samplemap and --samplestr are both specified, --samplemap wins.
 
 HOLDINGS EXTRACTION ARGUMENTS
-  --map          E::M::SM map file which will be used to extract holdings data
+  --map      -m   E::M::SM map file which will be used to extract holdings data
                  from the input MARC file
   --holdings -h  Specifies actual holdings tag
   --copyid   -c  Specifies subfield of holdings with unique copy identifier