args handling bug

[migration-tools.git] / extract_holdings

diff --git a/extract_holdings b/extract_holdings
index 22bc9c3..742c6e2 100755 (executable)
--- a/extract_holdings
+++ b/extract_holdings
@@ -6,7 +6,15 @@ use Getopt::Long;
 use Equinox::Migration::MapDrivenMARCXMLProc;
 use Equinox::Migration::MARCXMLSampler;
 
-my $VERSION = '1.000';
+my $VERSION = '1.001';
+
+=pod
+
+TODO
+
+  * Have detail mode report on number of subfields per datafield
+
+=cut
 
 my $c = initialize();
 $| = 1;
@@ -46,6 +54,7 @@ sub extract_holdings {
                 print "l_", $m->name($tagid, $sub),"\t"
                   if ($m->recno == 1);
             }
+
             for my $x (@{$rec->{tags}[$holdidx]{multi}{x}} ) {
                 print X $rec->{egid}, "\t",
                   $rec->{tags}[$holdidx]{uni}{ $c->{copyid} },
@@ -105,22 +114,29 @@ sub dump_sample_detail {
     my ($c, $s) = @_;
     my $tags = $s->{data}{samp};
     my $count = $s->{data}{rcnt};
+    my $scnt  = $s->{data}{scnt};
 
     open DETAIL, '>', ($c->{prefix} . "-HOLDINGS-DETAIL.txt");
     select DETAIL;
-    for my $tag (sort keys %{$tags}) {
-        print ">>>>> TAG $tag\n";
-        for my $subkey (sort keys %{$tags->{$tag}}) {
+    for my $tag (sort keys %{ $tags }) {
+        print ">>>>> TAG $tag\n\n";
+        for my $subkey (sort keys %{ $tags->{$tag} }) {
             my $sub = $tags->{$tag}{$subkey};
-            print "  Subfield: $subkey\n";
-            print "  Sample:   '", $sub->{value}, "'\n";
-            print "  Count:    ", $sub->{count}, " in ", $sub->{tcnt}, " tags\n\n";
-            #print "(", int($sub->{count} / $sub->{rcnt}), "%)\n";
+            print "|| $subkey | ", $sub->{value}, " | ", 
+              $sub->{count}, "/", $sub->{tcnt}, " |  ||\n";
         }
+        print "\n";
     }
-    select STDOUT;
-    print "\n";
     close DETAIL;
+    open SCOUNT, '>', ($c->{prefix} . "-HOLDINGS-SUBCOUNTS.txt");
+    select SCOUNT;
+    for my $tag (sort keys %{ $scnt }) {
+        print ">>>>> TAG $tag\n\n";
+        for my $len (sort keys %{ $scnt->{$tag} }) 
+          { print "|| $len | ", $scnt->{$tag}{$len}, " ||\n" }
+        print "\n";
+    }
+    select STDOUT;
 }
 
 sub dump_sample_overview {
@@ -176,7 +192,7 @@ sub initialize {
     show_help("Nothing to do!")
       unless ($c->{map} or $c->{sample} or $c->{samplemap} or $c->{samplestr});
     show_help("map, holdings, and copyid must be specified together!")
-      if ($c->{map} and !$c->{holdings} and !$c->{copyid});
+      if ($c->{map} and !($c->{holdings} and $c->{copyid}));
     show_version() if $c->{version};
 
     my @keys = keys %{$c};