fix retrieval of correct column headers and data from non-holdings tags

[migration-tools.git] / extract_holdings

diff --git a/extract_holdings b/extract_holdings
index 58b7575..fb44929 100755 (executable)
--- a/extract_holdings
+++ b/extract_holdings
@@ -33,6 +33,7 @@ sub extract_holdings {
                                                            mapfile  => $c->{map},
                                                            verbose  => 1,
                                                          );
+
     print "Writing holdings to output file(s)...\n";
     # open main holdings file
     open HOLDINGS, '>', ($c->{prefix} . "-HOLDINGS.pg");
@@ -79,20 +80,33 @@ sub extract_holdings {
             # now get everything else in the mapping
             for my $othertag ( sort keys %{$rec->{tmap}} ) {
                 next if $othertag eq $c->{holdings};  # ignoring the holdings, o'course
-                my $idx = $rec->{tmap}{$othertag}[0]; # get index into tags struct
-                unless (defined $idx) {
+                my $test_idx = $rec->{tmap}{$othertag}[0]; # get index into tags struct
+                unless (defined $test_idx) {
                     push @out, '';
                     next;
                 }
-                for my $sub ( sort keys %{$rec->{tags}[$idx]{uni}} ) {
-                    push @out, $rec->{tags}[$idx]{uni}{$sub};
-                    print HOLDINGS "l_", $m->name($rec->{tags}[$idx]{tag}, $sub), ", "
-                      unless $j;
+                # handle only first other tag unless it is known to be multi
+                my $limit = 0;
+                if (exists($multis->{$othertag})) {
+                    $limit = $#{ $rec->{tmap}{$othertag} };
                 }
-                for my $sub ( sort keys %{$multis->{$othertag}} ) {
-                    for my $value ( @{$rec->{tags}[$idx]{multi}{$sub}} ) {
-                        my $fh = $MULTIFILE{"$othertag$sub"};
-                        print $fh join("\t", $rec->{egid}, $j, $value), "\n";
+                foreach my $idx (0..$limit) {
+                    my $tag_idx = $rec->{tmap}{$othertag}[$idx];
+                    for my $sub ( sort keys %{$rec->{tags}[$tag_idx]{uni}} ) {
+                        if ($m->first_only($rec->{tags}[$tag_idx]{tag}, $sub)) {
+                            push @out, ($k == 1) ? $rec->{tags}[$tag_idx]{uni}{$sub} : '';
+                        } else {
+                            push @out, $rec->{tags}[$tag_idx]{uni}{$sub};
+                        }
+                        print HOLDINGS "l_", $m->name($rec->{tags}[$tag_idx]{tag}, $sub), ", " unless $j;
+                    }
+                    next unless exists($multis->{$othertag});
+                    for my $sub ( sort keys %{$multis->{$othertag}} ) {
+                        next if $m->first_only($rec->{tags}[$tag_idx]{tag}, $sub) and ($k > 1);
+                        for my $value ( @{$rec->{tags}[$tag_idx]{multi}{$sub}} ) {
+                            my $fh = $MULTIFILE{"$othertag$sub"};
+                            print $fh join("\t", $rec->{egid}, $j, $value), "\n";
+                        }
                     }
                 }
             }
@@ -243,21 +257,21 @@ REQUIRED ARGUMENTS
 
 SAMPLING ARGUMENTS
   --sample    -s   Generate a report of all tags in the MARC data
-  --samplemap -sm  Specify a E::M::STL map file which will be used to generate
-                   subfield breakdown reports about specific tags in the MARC
-                   data
+  --samplemap -sm  Specify a Equinox::Migration::SimpleTagList map file which
+                   will be used to generate subfield breakdown reports about
+                   specific tags in the MARC data
   --samplestr -ss  As above, but with a one-liner map specified on the command
                    line as a string (e.g. '-ss "852 999"')
 
   If --samplemap and --samplestr are both specified, --samplemap wins.
 
 HOLDINGS EXTRACTION ARGUMENTS
-  --map      -m   E::M::SM map file which will be used to extract holdings data
-                 from the input MARC file
+  --map      -m  Equinox::Migration::SubfieldMapper map file which will be
+                 used to extract holdings data from the input MARC file
   --holdings -h  Specifies actual holdings tag
   --copyid   -c  Specifies subfield of holdings with unique copy identifier
 
-  Both these must be given together.
+  All three of these must be given together.
 HELP
     exit;
 }