use Getopt::Long;
use MARC::Batch;
-use MARC::File::XML ( BinaryEncoding => 'utf-8' );
-use MARC::Field;
use Unicode::Normalize;
my $conf = {}; # configuration hashref
# date1, date2
my $my_008 = $record->field('008');
$my_008 = $my_008->as_string() if ($my_008);
- unless (length $my_008 == 40)
- { print XF ">> Bad 008 field length in rec. $id\n"; return \%marc }
+ unless (defined $my_008 and length $my_008 == 40)
+ { print XF ">> Bad 008 length in rec ",$marc{id},"\n"; return \%marc }
$marc{date1} = substr($my_008,7,4) if ($my_008);
$marc{date2} = substr($my_008,11,4) if ($my_008); # UNUSED
# "Accompanying material" (300e)
$marc{accomp} = $record->field('300')->subfield('e')
- if (defined $record->field('300')->subfield('e'));
+ if $record->field('300');
# issn, lccn, title, desc, pages, pub, pubyear, edition
$marc{lccn} = $record->field('010')->subfield('a') if $record->field('010');
$marc{desc} = $record->field('300')->subfield('a') if $record->field('300');
$marc{pages} = $1 if (defined $marc{desc} and $marc{desc} =~ /(\d+)/);
$marc{title} = $record->field('245')->subfield('a')
- if defined $record->field('245');
+ if $record->field('245');
$marc{edition} = $record->field('250')->subfield('a')
if $record->field('250');
if ($record->field('260')) {
}
print XF "Record ", $marc->{id}, " did not make the cut: ";
print XF "Missing item_form. " unless ($marc->{item_form});
- print XF "Missing date1. " unless (defined $marc->{date1});
- print XF "Invalid date1: ", $marc->{date1}
- unless ($marc->{date1} =~ /\d{4}/);
+ unless (defined $marc->{date1})
+ { print XF "Missing date1. " }
+ else
+ { print XF "Invalid date1: ", $marc->{date1}, " "
+ unless ($marc->{date1} =~ /\d{4}/); }
print XF "Missing record_type. " unless ($marc->{record_type});
print XF "Missing bib_lvl. " unless ($marc->{bib_lvl});
print XF "Missing title. " unless ($marc->{title});
my @keys = keys %{$c};
show_help() unless (@ARGV and @keys);
- for my $key ('runtype', 'tag', 'subfield', 'output', 'exception') {
- push @missing, $key unless $c->{$key}
- }
+ for my $key ('runtype', 'tag', 'subfield', 'output', 'exception')
+ { push @missing, $key unless $c->{$key} }
if (@missing) {
print "Required option: ", join(', ', @missing), " missing!\n";
show_help();
sub progress_ticker {
return if $conf->{quiet};
- printf("> %d (%d/s)\r", $count, ((time - $start) / $count))
+ printf("> %d (%d/s)\r", $count, ($count / (time - $start + 1)))
if ($count % 100 == 0);
}