removing unused modules

[migration-tools.git] / fingerprinter

diff --git a/fingerprinter b/fingerprinter
index addeaaf..06af0ff 100755 (executable)
--- a/fingerprinter
+++ b/fingerprinter
@@ -5,8 +5,6 @@ use open ':utf8';
 
 use Getopt::Long;
 use MARC::Batch;
-use MARC::File::XML ( BinaryEncoding => 'utf-8' );
-use MARC::Field;
 use Unicode::Normalize;
 
 my $conf  = {}; # configuration hashref
@@ -75,8 +73,8 @@ sub populate_marc {
     # date1, date2
     my $my_008 = $record->field('008');
     $my_008 = $my_008->as_string() if ($my_008);
-    unless (length $my_008 == 40)
-      { print XF ">> Bad 008 field length in rec. $id\n"; return \%marc }
+    unless (defined $my_008 and length $my_008 == 40)
+      { print XF ">> Bad 008 length in rec ",$marc{id},"\n"; return \%marc }
     $marc{date1} = substr($my_008,7,4) if ($my_008);
     $marc{date2} = substr($my_008,11,4) if ($my_008); # UNUSED
 
@@ -113,7 +111,7 @@ sub populate_marc {
     $marc{desc} = $record->field('300')->subfield('a') if $record->field('300');
     $marc{pages} = $1 if (defined $marc{desc} and $marc{desc} =~ /(\d+)/);
     $marc{title} = $record->field('245')->subfield('a')
-      if defined $record->field('245');
+      if $record->field('245');
     $marc{edition} = $record->field('250')->subfield('a')
       if $record->field('250');
     if ($record->field('260')) {
@@ -264,7 +262,7 @@ sub dump_exception {
     unless (defined $marc->{date1})
       { print XF "Missing date1. " }
     else
-      { print XF "Invalid date1: ", $marc->{date1}
+      { print XF "Invalid date1: ", $marc->{date1}, " "
           unless ($marc->{date1} =~ /\d{4}/); }
     print XF "Missing record_type. " unless ($marc->{record_type});
     print XF "Missing bib_lvl. " unless ($marc->{bib_lvl});
@@ -300,9 +298,8 @@ sub initialize {
 
     my @keys = keys %{$c};
     show_help() unless (@ARGV and @keys);
-    for my $key ('runtype', 'tag', 'subfield', 'output', 'exception') {
-        push @missing, $key unless $c->{$key}
-    }
+    for my $key ('runtype', 'tag', 'subfield', 'output', 'exception')
+      { push @missing, $key unless $c->{$key} }
     if (@missing) {
         print "Required option: ", join(', ', @missing), " missing!\n";
         show_help();